|
September 8, 2021 at 10:48 am
Hi Emily,
I’ll explain a little on how the promotions are applied so this makes more sense.
When a promotion code is submitted, EE first pulls the promotion object itself based on the code supplied.
What it does then works out if your cart has ‘items’ that are applicable to the current promotion it pulled from the above. It does this by first pulling all event objects in your current cart and saving them to an $events variable.
Then using the promotion object from above it pulls any objects (Events) that promotion applies to and saves those to a $redeemable_scope_promos variable.
As it now has both of those it can compare the $redeemable_scope_promos with the items you have in the cart to get the $applicable_items. So $applicable_items is any items you have in your cart that are also set on the promotion code for it to apply to.
After that, it filters $applicable_items to allow other plugins to hook in and change those items on the fly for whatever scenario they prefer, that filter is what the custom code on your site is using.
Now, the specific error you are getting when submitting the promotion codes in question means that $applicable_items is empty, but when I test your promotion codes set up exactly the same as how yours are on my test sites, they work fine. So we need to know if the issue is with the custom code you currently have hooking into work out the $applicable_items or something else.
When I mentioned disabling that custom plugin, I meant disable it for long enough for you to submit a promotion code that you know currently does not work and see if it works then. If you then re-enable the plugin and the same promotion code no longer works, there is an issue with what that custom plugin is doing which will need to be fixed.
—-
Is there a setting that is different within those two promo codes that is not working with the custom plug-in?
I can’t answer that as I didn’t write that custom plugin, I can tell you that the custom code you have is basically pulling ALL promotions on the site, looping over them all to get the ID’s for each of them. Like so:
$promotions = $promotionsinstance->get_all();
foreach ( $promotions as $p ) {
$id = $p->id();
array_push($promoids,$id);
}
Then looping over ALL EE events and pulling available tickets to do the same, loop over them and pull their ID’s:
$args = array( 'post_type' => 'espresso_events');
$loop = new WP_Query( $args );
while ( $loop->have_posts() ) {
$loop->the_post();
$eventid = get_the_ID();
$tickets = EEH_Event_View::event_tickets_available( $eventid );
foreach ( $tickets as $ticket ) {
$tid = $ticket->ID();
array_push($ticketids,$tid);
}
}
Then using array_fill_keys() to build and array of promotion ID’s that applies to every active ticket:
$allpromosandtickets=array_fill_keys($promoids,$ticketids);
Then filtering FHEE__EED_Promotions__get_applicable_items__applicable_items using $allpromosandtickets to work out if promotions are applicable and using a snippet we provided a while back as an example of ‘Ticket’ scopes on promotions to apply promotions to tickets:
https://github.com/eventespresso/ee-code-snippet-library/blob/master/addons/eea-promotions/bc_ee_ticket_scope_promotions.php
There’s a lot going on in that function that can be narrowed so it only works on the current events/tickets/promotion code in the cart before it passes anything to the function I linked above in $allpromosandtickets which may help here.
Ideally, you need a custom plugin that creates a ‘ticket’ scope for the promotions add-on as current it runs on everything.
I created another new promo code yesterday (webinar10) that appears to be working. What is different about FREEOERA2021 and CCC2021?
As far as I can tell, nothing, which is why you need to test this without that custom plugin running to narrow down if the issue is with the promotion itself or the custom code (I suspect it’s the latter).
|
