|
ardiaful
|
December 2, 2016 at 3:22 am
After I updated EE to version 4.9.22 I’ve started to notice two issues:
1) Website updates (under dashboard) no longer notifies me about new updates, unless I go and click on updates
2) I cannot longer open event Calendars and select a date in a session, instead I have to write yyyy-mm-dd and hour manually
|
|
ardiaful
|
December 2, 2016 at 3:40 am
I have tested this with Chrome, Firefox and MS Edge in last versions.
|
|
Tony
|
December 2, 2016 at 6:37 am
Hi there,
1) Website updates (under dashboard) no longer notifies me about new updates, unless I go and click on updates
Do you mean updates for Event Espresso or all plugins?
2) I cannot longer open event Calendars and select a date in a session, instead I have to write yyyy-mm-dd and hour manually
Is this the datepickers shown on the event editor? These – http://take.ms/YqCn5
If so its likely a plugin/theme conflict. If you open up Chrome dev tools on that page and look within the ‘console’ do you see any JS errors?
|
|
ardiaful
|
December 2, 2016 at 8:46 am
1) Yes, EE and all plugins. Updates only appear if I click on “updates” option, but no automatically
2) No JS error is found in console
|
|
ardiaful
|
December 2, 2016 at 8:49 am
Sorry, this is what Firefox console is showing
http://pictub.club/image/XfyWG
|
|
Tony
|
December 2, 2016 at 8:56 am
1) Yes, EE and all plugins. Updates only appear if I click on “updates” option, but no automatically
EE doesn’t have any effect on that section so this is unlikely to be caused by Event Espresso.
Are you using the latest version of WP?
Sorry, this is what Firefox console is showing
http://pictub.club/image/XfyWG
If you click within the datetime section (that would normally show the datepicker) is there an error then?
Did you recently update any other plugins or your theme?
|
|
ardiaful
|
December 2, 2016 at 1:19 pm
If you click within the datetime section (that would normally show the datepicker) is there an error then?
No, there is not any error, just the datepicker does not show up.
Did you recently update any other plugins or your theme?
Only plugins update so far are EE4 and EE WP User
|
|
ardiaful
|
December 2, 2016 at 1:34 pm
Also note that I’m running EE4.9.21 in a dev server and datepickers are showing alright.
|
|
Tony
|
December 2, 2016 at 1:52 pm
In 4.9.22 we made a change which should (in theory) make Event Espresso posts (more specifically the Event editor) a little more compatible with other plugins hooking into the admin.
This means that between 4.9.21 and 4.9.22 you may have additional plugins loading on the event edit which could be causing a conflict.
If you temporarily disable all Non EE plugins and retest the event editor page do the datepickers show?
If not also test switching to a default theme such as twentysixteen and confirm if the datepickers then show.
If you prefer not to do this on the live site you can install 4.9.22 on your dev site and confirm there, there are no migrations between those 2 version so you can safely roll back to the previous version without a problem.
|
|
ardiaful
|
December 2, 2016 at 2:10 pm
I updated to EE 4.9.22 in my dev server and problem with datepickers then appears.
|
|
Tony
|
December 2, 2016 at 2:26 pm
Did you test with all non-EE plugins de-activated? (and also a default theme if the same happens with no plugins)
|
|
ardiaful
|
December 2, 2016 at 2:53 pm
YEs, I tested all non-EE plugins and the issue arises with plugin “Advanced Custom Fields” v4.4.11 by elliotcondon.
http://www.elliotcondon.com/
|
|
Tony
|
December 2, 2016 at 3:06 pm
I run ACF on multiple test sites without any issues so it may be a specific field causing this.
Which fields do you have activated within ACF for the Event Editor? Can I take a look so and see if I can spot any problems?
If so you can send temporary login details using this form:
https://eventespresso.com/send-login-details/
|
|
ardiaful
|
December 2, 2016 at 3:31 pm
I have just sent you temporary login credentials to my dev server. Please check.
Fields activated within ACF are:
– espresso_people:
– New text field for bank account data
– New social links for speaker
– espresso_events:
– Image gallery
– featured event
– order of featured event
– related events
– event video
|
|
Josh
|
December 2, 2016 at 4:33 pm
Advanced Custom Fields isn’t actually causing the conflict. It’s actually the Januas theme. Even if ACF is deactivated, the Januas theme is highjacking the Event Espresso event editor’s date time calendar selectors. The way forward is Showthemes can look into only loading their date picker scripts where needed. You’ll find that Event Espresso doesn’t load its date picker scripts anywhere other than where they are needed.
|
|
ardiaful
|
December 3, 2016 at 6:34 am
But I don’t need Januas theme to load its datepickers scripts anywhere, only EE shoud. So, if I understand well, by disabling Januas datepicker script only EE script would load, and this would get fixed?
|
|
Tony
|
December 5, 2016 at 9:27 am
By disabling the Januas script only EE’s script should be the one to load however again if there some other plugin doing something similar it can happen.
I would recommend creating a ticket with ShowThemes to investigate this further, however currently you could de-register the script when loading the EE event editor using something like this:
https://gist.github.com/Pebblo/026e24996b32db5590128c86425d685e
You can that to a Custom Functions Plugin or your child themes functions.php file.
|
|
ardiaful
|
December 5, 2016 at 10:14 am
Regretfully removing the Januas ‘cmb-scripts’ script file does not work for me. Which makes me think the issues originates elsewhere, as with Advanced Custom Fields (I deactivate the ACF plugin and date pickers come back to life).
|
|
Tony
|
December 5, 2016 at 10:37 am
Have you confirmed that file now isn’t loading on the event editor using Chrome dev tools or similar?
The reason being I loaded both Januas and ACF on a local test site to reproduce the problem, then de-registered the script using the above and it worked correctly.
|
|
Josh
|
December 5, 2016 at 10:38 am
That’s incorrect. If you switch to another theme, then reactivate ACF does the event editor work as expected?
You can use the theme test drive plugin to test another theme as the administration without affecting the front end of the site.
|
|
ardiaful
|
December 5, 2016 at 11:16 am
Well Josh, yes, you are right. If I switch to another theme, the event date pickers work as expected.
|
|
ardiaful
|
December 5, 2016 at 11:27 am
@Tony, it seems jquery.cmbScript is still loading from the Januas theme, not the Januas theme child
|
|
ardiaful
|
December 5, 2016 at 11:32 am
Check this screenshot https://postimg.org/image/5um8pt4fn/
|
|
Josh
|
December 5, 2016 at 12:22 pm
The workaround script that Tony shared with you might be failing on the $pagenow check. This is another variation on how to remove the Januas scripts from the EE editor page that doesn’t use that check:
function tw_ee_remove_scripts_from_event_editor(){
remove_action( 'admin_enqueue_scripts', 'cmb_scripts', 10 );
}
add_action( 'add_meta_boxes_espresso_events', 'tw_ee_remove_scripts_from_event_editor' );
You can add the above to a functions plugin or into your WordPress theme’s functions.php file.
|
|
ardiaful
|
December 5, 2016 at 12:36 pm
YES, this script works good for me! Really appreciate your help to solve this issue.
|
|
Josh
|
December 5, 2016 at 12:42 pm
I’m afraid what we’ve shared with you is not a viable long term solution. Please contact Showthemes and open a support token with them about this so they can fix their code so it doesn’t break other plugins.
|
|
ardiaful
|
December 5, 2016 at 12:49 pm
Agree, will do.
|
