|
codingforsail
|
January 18, 2018 at 6:28 am
I noticed a couple of errors in the wording of the error messages in one particular file. I can correct these in my version but know that this will get overwritten if the file concerned is changed.
File:
event-espresso-core-reg/modules/single_page_checkout/EED_Single_Page_Checkout.module.php
Line 236: “you’re registration time” should be “your registration time”
Line 236: “Please except our apologies” should be “Please accept our apologies”
Line 1507: “Please except our apologies” should be “Please accept our apologies”
|
|
Tony
|
January 18, 2018 at 7:04 am
Hi there,
Thank you for reporting this, I’ve created a ticket for those to be fixed in the next version of Event Espresso.
Just to note, you mentioned above you would lose the fix if that specific file was changed, that’s not the case if using the standard WP updates. The entire plugin’s directory is removed and then replaced with the new version, so any customizations to any core plugin files will be lost on any update to that plugin, even if the file in question was not actually changed during the update.
Not trying to be nit-picky with the above but it’s an important note 🙂
|
|
codingforsail
|
January 18, 2018 at 7:23 am
Thanks for clarifying about the updates. It would indeed be standard WP updates. I thought it worked like that but wasn’t sure why. Deleting the directory makes sense.
|
|
Tony
|
January 18, 2018 at 9:25 am
No problem, I’ve seen a few people mention that previously and I’m not sure where it’s from.
Generally, we advise against any customization to the core code and provide a ton of hooks to change/add functionality if needed so it’s much better to use those.
|
