|
Even Onsager
|
October 9, 2014 at 8:45 am
I’m using EE 3.1.36.5P with EE REM 1.1.8, and I have an issue.
Using this Gist from Github provided by Josh Feck I get nice grouped lists of recurring events, and I’m really happy with it. It also works really well with waiting lists, as it gives a nice overview of the available dates at a glance.
However, now I’ve made my first events without waitlists in years (usually all my events need them), and when one event is full, the “Join waiting list” link still appears even without waiting list assigned. The link itself takes me to /?page_id=9&ee=0 (page_id=9 is the page with my registration shortcode), the page where all my events appear regardless of event_list, and it’s thus useless.
I’m happy with the rest of the behaviour, so could you help me update this gist manually so that the link only appears when a waitlist is actually assigned?
Thanks in advance!
|
|
Josh
|
October 9, 2014 at 3:16 pm
Hi Even,
The gist you linked to is out of date. If you open up the current version of the recurring events plugin, you’ll find a folder labeled /templates where you’ll find updated version of the event list templates designed to be used with the recurring events add-on.
The updated version includes a check for whether the event has a waitlist.
|
|
Even Onsager
|
October 10, 2014 at 2:59 am
I replaced the old versions with the ones from the espresso-recurring/recurring-event-templates folder, and it gives me the exact same error. I notice there’s one line changed (line 84) from the gist, but it doesn’t seem to help with my issue.
I created a test event and put it on a page using the event_list shortcode, so you can see the issue for yourself. Here: http://event.khio.no/test. The event “Test” does not have an overflow event assigned and the assign waitlist dropdown is set to NO.
I’ve had some weird language-related issues before, but I just set up a clean English-language install of WP/EE/EE-REM and the issue is the same.
Any ideas? Can you replicate the issue on your end?
|
|
Dean
|
October 10, 2014 at 3:11 am
Hi,
I tested with EE 3.1.36.6 and REM 1.1.8 (using the templates in the plugin folder) and could not replicate this: screenshot http://take.ms/Zp5ih
Did you modify any of the core EE files at all? Are there any template files in the uploads/espresso/templates folder (excluding the two you added from the REM addon)?
|
|
Even Onsager
|
October 10, 2014 at 3:29 am
Maybe I was being unclear… This affects only events that are SOLD OUT but does not have waiting lists. I can’t see any sold out events in your screenshot. When there are spaces available, all is fine.
|
|
Even Onsager
|
October 10, 2014 at 3:31 am
I.e. I want my test event to only say SOLD OUT.
|
|
Tony
|
October 10, 2014 at 4:38 am
Hi Even,
This has been fixed within the latest version of REM templates included within the next version of REM. You can test this version by joining the PR Channel.
I have also uploaded the current templates here: http://take.ms/Uc57O
Here is how they work – http://take.ms/R39sy
Also to note the way these new template work is to check if the ‘Assign a Waitlist Event?’ option is set to yes, if so display the link. Simply setting the event with this option to ‘No’ will hide the link – http://take.ms/6ps7K
The current version uses an older method for waitlist events so displays the link when no waitlist event has been assigned.
|
|
Even Onsager
|
October 10, 2014 at 4:56 am
Thanks! I’ll try that in a couple of hours. Can I use the templates without upgrading ot the pre-release, or do I have to upgrade first?
|
|
Tony
|
October 10, 2014 at 5:05 am
The templates themselves should be independent of REM so you should not need to update if you do not want to.
The PR vesion of REM does include fixes for issues seen by some users when creating/updating a recurring series. If you have not had any issues you can continue using the current version whilst we test the other.
|
|
Even Onsager
|
October 10, 2014 at 8:50 am
@Tony Warwick: OK, updating only the templates did not help. Exact same issue – check event.khio.no/test.
I also tested setting an overflow event without saying yes to assigning a waitlist event (why is this even possible, btw, shouldn’t it logically be grayed-out?), and it sent me to the chosen overflow event anyway. I’m suspecting it sends me to the fictional page_id=9&ee=0 because id=0 it tries to find “Select event”.
@Dean, I’m pretty sure I haven’t modified any core files. I’m updating regularly, and they would be lost, no? I have modified versions of registration_page.php, …display.php and return_payment.php in my templates folder, but that shouldn’t be an issue with event_list_display.php.
|
|
Tony
|
October 10, 2014 at 10:16 am
Hi Evan,
My apologies, the template version I uploaded was a version that had the fix applied to the recurring events, but not for the standard events.
This version has the fix applied to both – http://take.ms/zbnTO
Can you confirm if this fixes your issue?
|
|
Even Onsager
|
October 10, 2014 at 10:35 am
It works! Beautiful! Thanks a lot!
(Another less important thing I noticed just now: some of the strings both in the gist and the new templates are untranslated. In the EE core event_list sold out would be translated as “fullt” in Norwegian. Also, the time and date format doesn’t follow my wordpress standard like the rest of EE does. I’ll just customize it myself in the event_list_display.php this time (I’ve done this before by editing carefully), but if you could fix this for a later release that’d be wonderful.)
|
|
Josh
|
October 10, 2014 at 10:51 am
Thanks for the feedback.
|
