Support

June 4, 2019 at 8:23 am

Hi,

It looks like the way your custom code is pulling the prices, it’s setting a variable somewhere, so that June 4 class price at 190.00 is getting through to the next loop. In other words, you need to initialize your price variable so it always starts as 0 or an empty string.

Looking at the gist from your other topic, what you could do is right after this line:
//check if the ticket is free, if set the ticket price to 'Free'
add this:
$ticket_price = 0;
add that just before:
if ( $ticket instanceof EE_Ticket ) {

June 4, 2019 at 9:58 am

Oh okay, yeah I see further up above there’s some logic that doesn’t check for the tickets if the event is sold out. So the tickets from one event can end up being used for other events. What you’ll need to do is go through and initialize any variables that need to be unique for each event, when there’s any chance that they might not get set due to logic.

So for example, to fix the above problem where you have this:

if ( ! $event->is_sold_out() ) {

            // grab array of EE_Ticket objects for event
$tickets = EEH_Event_View::event_tickets_available( $post->ID );

You’ll need to either remove that sold out check, or initialize the $tickets variable, or add an else statement that also gets the tickets, then does something else. The entire template could use some cleaning up and a code review because there could be some other gotchas in there.

June 4, 2019 at 11:05 am

I’m not 100% sure how to fix this as it’s not my code or code I normally support, and the code has a lot of extra things that don’t make sense to me. So I hope you can understand this isn’t a case of not being kind enough to help, it’s a case of not knowing exactly how to fix someone else’s code. So you may need to do some trial and error with this.

If I were going to troubleshoot this, I’d start with moving the if statement after that sold out check so the $tickets object gets set even if the event is sold out. In other words, move this:
if ( ! $event->is_sold_out() ) {
to the line after this:
$tickets = EEH_Event_View::event_tickets_available( $post->ID );

Again, I don’t know if that’s going to fix the issue. There’s over a 1000 lines of code in that template and it probably has other gotchas that aren’t in the templates we provide and support.

June 4, 2019 at 11:47 am

So if you undo the changes that Tony advised does that fix the issue?

June 4, 2019 at 12:43 pm

He didn’t exactly solve the problem, he pointed you in the direction of a solution and the solution wasn’t followed through fully. The solution is really something that a developer really needs to do, because again, we do not support adding prices to this template. Adding pricing there adds so much complexity to an otherwise simple template.

So that said, back to the issue where you have variables that are not initialized. On line 358, you have a $cap_required variable being set, but it’s not initialized. You’ll need to initialize that variable so the next ticket to get looped through doesn’t get the same variable because the other ticket doesn’t have a required ticket cap.

June 6, 2019 at 10:33 am

The problem is that in your other post you requested we only use a ticket that has no capability set on it, but with these events, it seems there are only member tickets (or a single member ticket) all with a capability set on them (it), right?

You can’t set up those events different with the way the code is now as it expects at least 1 ticket not to have a capability.

So there’s a couple of steps to fixing this.

First, add:

// initialize $ticket
$ticket = null;

You can add that just after this line: https://gist.github.com/altuno/394a15ad09009d55407baab884438e7a#file-template-oa-L354

Then just after the code I gave you previously, add this:

// If at this point we have tickets, but a single ticket has not been found then all of the tickets on the event have a capability,
// so let's pull the first ticket we have and use that.
if(is_null($ticket) && !empty($tickets)) {
    $ticket = reset($tickets);
}

Which is basically saying if the code I gave you earlier didn’t find a ticket, go back to pulling the first ticket from $tickets again. So it looks a little something like this:

// grab array of EE_Ticket objects for event
$tickets = EEH_Event_View::event_tickets_available( $post->ID );
// initialize $ticket
$ticket = null;

//Loop through all of the available tickets and set $ticket to the first ticket found without a capability
foreach($tickets as $temp_ticket) {
    if($temp_ticket instanceof EE_Ticket) {
        // Pull the capability set on the ticket
        $cap_required = $temp_ticket->get_extra_meta('ee_ticket_cap_required', true);
        // We want a ticket with no cap set
        if(!$cap_required) {
            $ticket = $temp_ticket;
            break;
        }
    }
}

// If at this point we have tickets, but a single ticket has not been found then all of the tickets on the event have a capability,
// so lets pull the first ticket we have and use that.
if(is_null($ticket) && !empty($tickets)) {
    $ticket = reset($tickets);
}

As Josh mentioned, the code in that template is getting rather cluttered and could do with a refactor, there are a fair few unnessacary steps going on in that template now.

June 10, 2019 at 6:43 am

The reason that is happening is the event status is not sold out, so this check:

if ( ! $event->is_sold_out() ) {

Is returning that the event is not sold out and it’s running through all of the ticket set up.

I know that is happening because of the banner on the event page – https://monosnap.com/file/MS6QWmnI5ExrGXxNT0Ovr8hZO1ijeC

Example of a sold out event – https://monosnap.com/file/HmxahqR3KodFo4RkAHsSeFFIxm3XPk

That info is also available in a couple of other locations, but the point being the event does not have a status of sold out, the ticket current does, but not the event, so the code is working as expected.

June 13, 2019 at 4:03 pm

I did some digging into this and it looks like its a bug caused by the archived ticket not being included in the sold out check.

I’ve created a ticket to investigate this further, for the time being, you will need to manually set that event to sold out in order for it to show as such.

June 18, 2019 at 9:47 am

The fix in EE4 core was included in the very latest release (v. 4.9.82.p)