|
Lee Collier
|
December 9, 2017 at 9:06 am
Hi,
I am updating a site based around the lumino theme (https://themeforest.net/item/lumino-responsive-multifunctional-theme/15752995). The beta site I was using to test all the updates worked well including EE integration, after some help (see https://eventespresso.com/topic/lumino-theme-conflict/). Merging the updated pages back into the new site, I now have issues with the theme menus appearing right at the top of the page (rather than centred in the page header where they should be) and some key functions not working, including a function in the theme that checks the viewport size and resizes some page elements to fit.
After lots of messing around I’ve tracked it down to EE. The beta site is pinned at 4.9.45 version of Core as it lacks a support license. The production site was automatically updated to 4.9.53. Downgrading the production site to 4.9.45 fixes the problem.
I’m not sure whether this is a true issue with EE or a badly coded theme, but I’m quite invested in this theme now…
Any thoughts?
Lee
|
|
Lee Collier
|
December 9, 2017 at 1:22 pm
Update: I’ve discovered that downgrading as above solves the problem for the main pages on my site, but the pages generated by EE still have the same issues.
I’ve noticed that EE seems to be inserting HTML before the <head> of the document, e.g.
<div id="espresso-notices"></div>
<div id="espresso-ajax-loading" style="display:none;">
<span class="ee-spinner ee-spin"></span><span style="display:none;">loading...</span>
</div>
<div id="espresso-ajax-notices">
<div id="espresso-ajax-notices-success" class="espresso-ajax-notices success fade-away" style="display:none;">
<a class="close-espresso-notice"><span class="dashicons dashicons-no"></span></a>
<p class="espresso-notices-msg"></p>
</div>
<div id="espresso-ajax-notices-attention" class="espresso-ajax-notices attention fade-away" style="display:none;">
<a class="close-espresso-notice"><span class="dashicons dashicons-no"></span></a>
<p class="espresso-notices-msg"></p>
</div>
<div id="espresso-ajax-notices-error" class="espresso-ajax-notices error fade-away" style="display:none;">
<a class="close-espresso-notice"><span class="dashicons dashicons-no"></span></a>
<p class="espresso-notices-msg"></p>
</div>
</div>
<!DOCTYPE html>
<!--[if IE 9]> <html lang="en-GB" class="no-js ie9"> <![endif]-->
<!--[if gt IE 9]><!--> <html lang="en-GB" class="no-js"> <!--<![endif]-->
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="profile" href="http://gmpg.org/xfn/11">
<link rel="pingback" href="https://jubilee.co/xmlrpc.php">...
An example can be seen here: https://jubilee.co/book/school-of-the-word-unlock-the-bible-term-2-2017-2018-2/
|
|
Josh
|
December 11, 2017 at 8:47 am
Hi Lee,
You can fix this by adding a conditional to wherever the theme hooks into loop_start or if it starts the loop before WordPress starts the loop. If you can upload the theme to a service like Dropbox and post a download link here we can take a look at the theme’s code and suggest a fix.
|
|
Lee Collier
|
December 11, 2017 at 11:57 am
Thank you for your help. I’ve uploaded the theme file here: https://www.dropbox.com/s/4spebheubr019m0/themeforest-15752995-lumino-responsive-multifunctional-theme-wordpress-theme.zip?dl=0
|
|
Josh
|
December 11, 2017 at 3:23 pm
Thanks for the link. I loaded Lumino onto my dev site and no layout issues there. Hilarity ensues only after activating the “recommended” WPBakery Visual Composer plugin. It appears that version 4.12.1 of Visual Composer is bundled with Lumino, and it also appears there is a newer version available, so there may be a fix in the newer version. Are you using WPBakery on that site and if does it have the current version of WPBakery?
|
|
Lee Collier
|
December 11, 2017 at 9:44 pm
Thanks for your help.
I have got an updated version, which I’ve uploaded here: https://www.dropbox.com/s/h5ztykm1a2idmg7/bakery.zip?dl=0
However on my development site it’s not making a difference when I enable or disable Visual Composer (now called WP Bakery Page Builder). Having disabled then re-enabled everything it seems to be CiviCRM plugin that’s conflicting, which is probably far from a simple fix :(.
Would you be happy to take a look? Is there a way to private message you a password to my dev site, as I doubt you want to install CiviCRM.
|
|
Lee Collier
|
December 11, 2017 at 10:04 pm
Looking at other posts, adding the following filter to a custom plugin solves the problem, but I guess that will remove the AJAX spinner and error messages during checkout..?
add_filter( 'FHEE__EE_Front_Controller__display_errors', '__return_false' );
|
|
Josh
|
December 12, 2017 at 8:04 am
That’s correct, but what you can do instead is delay that code so it fires later with the main loop instead of with the early loop. Can you add the following to a custom functions plugin, then activate the plugin?
function move_ee_notices_to_main_loop() {
add_filter('FHEE__EE_Front_Controller__display_errors', '__return_true');
return false;
}
function remove_ee_notices_from_early_loop() {
if(!did_action('wp_head')) {
add_filter(
'FHEE__EE_Front_Controller__display_errors',
'move_ee_notices_to_main_loop'
);
}
}
add_action('loop_start', 'remove_ee_notices_from_early_loop', 2);
|
|
Lee Collier
|
December 12, 2017 at 8:22 am
That’s got it, thank you! I guess something in CiviCRM is starting a loop before the page header is done.
|
