Support

January 29, 2024 at 5:19 pm

Can you give us more information about the problem you’re experiencing? Can you shoot a video, you can use loom to do it. https://loom.com/

We also recommend to put the error log in this thread so we can see the problem.

Can you also tell us your site system information?
WP Version
Php Version
EE Version.

You also mention that problem since the weekend update? Can you share us what update you did? is it the EE update? or other theme or plugin update you have?
If it’s EE update, what was your prior version?

thanks

January 31, 2024 at 1:32 pm

Hi there,

This error:

PHP message: PHP Fatal error: Uncaught TypeError: EE_Admin_Page_CPT::modify_edit_post_link(): Argument #1 ($link) must be of type string, null given

Is from code that has been within Event Espresso since version 5.0.0, so it’s been in the release for a long time and wasn’t just introduced in the latest update over the weekend.

Did you update other plugins over the weekend?

It looks like something is hooking into the get_edit_post_link and returning null, as EE is expecting a string it throws a fatal error.

February 1, 2024 at 11:24 am

It may be the original code, but it is causing an issue now, perhaps with some new code.

I understand, but the point is that code didn’t change with our update over the weekend and it’s been in core for years (November 2022 is the comment for the string typed property which is throwing the error).

So something else on the site is now hooking in and returning null to the get_edit_post_link filter, meaning its been sett to null before our method hooks in so it now it throws a fatal as it expects a string.

I ran a grep -rnw on the plugins and theme files, and following are the only files using this function:

cool_cpr@crack-ajax:~/httpdocs/wp-content$ grep -rnw ‘modify_edit_post_link’ plugins/

But you’re searching for EE’s method name, so yes, that’s going to show up in Event Espresso because that’s the name of our method hooking into the get_edit_post_link hook.

Do you get more results from:

grep -rnw 'get_edit_post_link' plugins/

—

You can temporarily stop that fatal by changing plugins/event-espresso-core-reg/core/admin/EE_Admin_Page_CPT.core.php:1165 from this:

public function modify_edit_post_link(string $link, int $id): string

To this:

public function modify_edit_post_link($link, $id)

However, the fatal being thrown there is a symptom of some other code on the site hooking to the above hook and returning an unexpected value which EE then tries to use and throws a fatal so I’d recommend finding the code doing that rather than the above ‘fix’.

One option for doing that is using the Health Check & Troubleshooting plugin but first, do a quick Database backup if you don’t have one already (just to be on the safe side).

Then install and activate this plugin:

https://wordpress.org/plugins/health-check/

Add that to the site and go to Dashboard -> Settings -> Site Health -> Troubleshooting.

Enable Troubleshooting mode.

That disables all plugins and switches you back to a default theme, but only for the logged-in Administrator.

Then do to the Admin Bar -> Troubleshooting Mode -> Manage Active Plugins.

Enable Event Espresso in troubleshooting mode.

Test the condition for the fatal above.

The work through enabling each individual plugin that you have active on the site in troubleshooting and test the above between each one to find which one causes the fatal.

It could also be something within the theme, troubleshooting mode in the admin menu lets you switch themes. Test again.

When finished go to Admin Menu -> Disable Troubleshooting mode to switch back to ‘normal’ mode again.

February 1, 2024 at 12:54 pm

Nice find.

Ironically, the changelog for version 7.1.0 of WCP has this:

Fix – Prevent possible fatal when using get_edit_post_link filter.

In which they added the code to return null for that filter, I’m not so sure returning null when it’s expected to be a string prevents fatal’s elsewhere but it obviously worked for them 🙂

I’ll create a ticket to discuss this further, based on what we use that value for we can possibly relax the typing a little here to allow for null.