|
Erica Vandiver
|
July 13, 2017 at 8:10 am
Hello! I have two EE4 sites. One site (“Online”) missed the WP 4.8 update, and is on WP 4.6, and is functioning as expected. That site is running EE 4.8.26.p.
The other site (“Orientation”) is on WP 4.8 and EE 4.9.28.
Looking at an event on Online, https://online.stlcc.edu/events/florissant-valley-new-student-registration-workshop-271/, you can see the sidebar is on the side and the footer is at the bottom. If you inspect the page, you’ll see that “footer” in inside the “page” div.
Looking at an event on Orientation, https://orientation.stlcc.edu/events/fv-archer-orientation-1917-10am/, you can see the sidebar has dropped to the end of the page, and the footer is at the bottom, after the page, overlaying the backdrop. Inspector shows that the footer is now outside the “page” div. I have no idea why the sidebar has dropped.
Please help me get Orientation to present the way that Online does. I recopied my child theme from Online to Orientation on my dev sites (not publicly accessible), and the behavior is the same. Thanks in advance!
|
|
Josh
|
July 13, 2017 at 8:54 am
Hi there,
You can update to the current version of Event Espresso 4 (currently 4.9.43.p) and that will fix the issue you’re seeing on the Orientation site.
|
|
Erica Vandiver
|
July 13, 2017 at 10:44 am
I updated online-dev to WP 4.8 & all EE plugins (EE, EE Calendar, Events Table View). This has created the issue this site, whereas it was not there before the updates.
|
|
Josh
|
July 13, 2017 at 10:50 am
Hi there,
orientation.stlcc.edu has version 4.9.28.p. The current version of Event Espresso is 4.9.43.p, so orientation.stlcc.edu is 15 version releases behind current. If you update orientation.stlcc.edu to 4.9.43.p it will fix your issue.
|
|
Erica Vandiver
|
July 13, 2017 at 10:53 am
I see that I wasn’t clear. I updated one of my dev sites which was working fine from EE 4.8.26.p to 4.9.43.p and the problem is now present on that site.
|
|
Josh
|
July 13, 2017 at 10:59 am
Can you post a link to the page on the site that has 4.9.43.p?
|
|
Erica Vandiver
|
July 13, 2017 at 11:07 am
I can screenshare or you can see screenshots here, but again my dev sites are not publicly accessible.
|
|
Josh
|
July 13, 2017 at 11:16 am
Screenshots will not help in this case. We’d need to see actual HTML. Can you use a tool like Firefox Web Developer bar and get the source of the page, then post the source to a gist or pastebin, then link here?
|
|
Erica Vandiver
|
July 13, 2017 at 11:24 am
Sure thing. Pastebin
|
|
Josh
|
July 13, 2017 at 9:16 pm
Hi Kris,
Did you or a developer that worked on this site make some customizations to the ticket selector templates? The reason I ask is because on line 282 of your pastebin there’s a comment:
<?//*Rewritten available tickets*/?>
Then a bit later on line 296 there’s an extra closing </div> tag that doesn’t have a matching opening div tag. If you can remove that extra closing div tag (or even add an opening div tag earlier on if you prefer) that will fix your formatting issue.
|
|
Erica Vandiver
|
July 14, 2017 at 7:35 am
That was in
\wp-content\uploads\espresso\templates\ticket_selector_chart.template.php
I removed the div and refreshed – no change. See Pastebin
|
|
Josh
|
July 14, 2017 at 8:29 am
If you temporarily remove the hook to load the custom ticket selector file (so that it does not load) does that correct the layout issue?
|
|
Erica Vandiver
|
July 14, 2017 at 9:05 am
How do I do that?
|
|
Josh
|
July 14, 2017 at 9:27 am
I don’t know, because the later versions of Event Espresso 4 do not have or use a “ticket_selector_chart.template.php” file. So I’m assuming you have some custom code that’s overriding the default behavior.
|
|
Erica Vandiver
|
July 14, 2017 at 11:13 am
It is “custom”, via Tony Warwick’s advice. See his answer to question 1 in this forum post.
|
|
Josh
|
July 14, 2017 at 12:03 pm
Tony’s answer was regarding the Events table template plugin, which involves editing the espresso-events-table-template.template.php file.
|
|
Erica Vandiver
|
July 14, 2017 at 12:08 pm
OK. I’ve removed the whole file and the issue is still there.
|
|
Josh
|
July 14, 2017 at 12:28 pm
Which file? Can you share the view source of the page with that change in effect?
|
|
Erica Vandiver
|
July 14, 2017 at 2:47 pm
ticket_selector_chart.template, the only file that is currently in \wp-content\uploads\espresso\templates. Sure thing – Pastebin
|
|
Josh
|
July 14, 2017 at 4:10 pm
Hi Kris,
If you look at the page, do you see how the entire ticket selector table is gone now? There’s quite likely some additional customizations loading either from a theme functions.php file or another plugin that’s telling Event Espresso to not load its ticket selector template. If you can find that customization and deactivate it, that will fix the layout issues.
|
|
Josh
|
July 14, 2017 at 4:19 pm
More than likely your code will be adding a filter function to this hook:
FHEE__EE_Ticket_Selector__display_ticket_selector__template_path
|
|
Erica Vandiver
|
July 18, 2017 at 8:06 am
Hi Josh. Let’s try this again. I have an exact clone of online.stlcc.edu. On the clone, I have updated :
WordPress from 4.6 to 4.8
Members from 1.1.1 to 1.1.3
EE Calendar from 3.2.6.p to 3.2.10.p
EE Table View Template from 1.3.3.p to 1.3.6.p
At this point, everything is fine. It is only when I update EE from 4.8.26.p to 4.9.44.p that the sidebar and footer go wonky.
|
|
Josh
|
July 18, 2017 at 8:51 am
Have you checked your site to see if you have a callback function on the
FHEE__EE_Ticket_Selector__display_ticket_selector__template_path hook?
The reason you’re running into issues with the new version is because the new version has some changes to the ticket selector template. You have some code on your site that’s loading in an older version of the ticket selector template. Your custom code needs to be updated to be compatible with the current version.
|
|
Erica Vandiver
|
July 18, 2017 at 8:53 am
What does a callback function look like?
|
|
Josh
|
July 18, 2017 at 9:05 am
It will look like this:
add_filter ('FHEE__EE_Ticket_Selector__display_ticket_selector__template_path', 'ee_custom_ticket_selector_template_location');
function ee_custom_ticket_selector_template_location(){
return WP_CONTENT_DIR . '/uploads/espresso/templates/ticket_selector_chart.template.php';
}
|
|
Erica Vandiver
|
July 19, 2017 at 10:36 am
I see – thanks! I think with the updated release I don’t need the customization anymore, so I will delete the function. I appreciate your patience!
|
